[Bug 750800] rtsp-media: always use real payloader when creating streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750800

--- Comment #7 from Ognyan Tonchev (redstar_) <ognyan.tonchev at axis.com> ---
(In reply to Sebastian Dröge (slomo) from comment #5)
> Review of attachment 305277 [details] [review]:
> 
> ::: gst/rtsp-server/rtsp-media.c
> @@ +1457,3 @@
> +      if (pay == NULL) {
> +        GST_WARNING ("could not find real payloader, using bin");
> +        gst_rtsp_media_create_stream (media, elem, pad);
> 
> Why is this a warning? Should only be one if GST_IS_BIN(elem), right?
> Otherwise we just have the plain payloader as elem?

find_payload_element() can only return NULL when elem is a GstBin and there is
no element which inherits from GstBaseRTPPayload in it.
May be there should be a g_assert instead before the warning: g_assert
(GST_IS_BIN (elem))?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.