[Bug 750310] Ideas around GstGLContextGPUProcess

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750310

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305317|none                        |needs-work
             status|                            |

--- Comment #8 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 305317:
 --> (https://bugzilla.gnome.org/review?bug=750310&attachment=305317)

(In reply to Julien Isorce from comment #7)
> Created attachment 305317 [details] [review]
> gldisplay: add create-context signal
> 
> Matthew I could not move context_new/create dance to
> gst_gl_display_create_context because of window id. Indeed it is not easy so
> I suggest to do it separately later.
> 
> Also since I create the gstgldisplay from the app, I wonder if I could just
> pass the gpucontext at this time (with gst_gl_display_make_one_to_one
> (display, context) or something) and also add a helper/property to check
> whether the pair display/context is one-to-one. But I am fine with the
> signal.

The set_window_handle is already done after context creation anyway so yes, you
can move the _new/_create() to a new helper and have glimagesink call it and
set the window id later.  You don't need any extra functions to pass the
context from the app to the pipeline, as long as you add the context to the the
display with gst_gl_display_add_context, the elements will find it already. 
However, that is slated to change for the one context per streaming thread bug
to be dependent on calling threads.  Which is why the new signal is needed to
do this.

::: ext/gl/gstglimagesink.c
@@ +612,3 @@
   if (!gl_sink->context) {
+    if (gst_gl_display_create_context (gl_sink->display, &gl_sink->context)) {
+      GstGLWindow *window = gst_gl_context_get_window (gl_sink->context);

This whole entire if block needs to disappear and the
gst_gl_display_create_context needs to replace the later
gst_gl_context_new/gst_gl_context_create.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.