[Bug 750965] rtpjitterbuffer: 1. Fix a typing error of comment, 2. Add null check in free_item function

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jun 16 07:39:58 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750965

--- Comment #13 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
> Maybe that's what you mean, though it felt unclear to me. g_return_* will
> leave the if () return block when "compiling out".

No: https://git.gnome.org/browse/glib/tree/glib/gmessages.h#n326

> Unlike g_assert which will complete go away.

This is true. I wasn't meaning to suggest that g_assert() is better or safer
than g_return_if_*(), just that g_return_if_*() should generally only be used
for public API to catch programmer errors, not in internal code.

Anyway, sorry for the bikeshedding :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list