[Bug 736896] [REGRESSION] pygobject 3.13 now copies the GstStructure when getting them from a GstCaps, making it impossible to properly modify structures from caps in place.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=736896

--- Comment #21 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to John Slade from comment #20)
> @Thibault I have tested your gst-python patches
> http://cgit.collabora.com/git/user/tsaunier/gst-python/ under Fedora 21 and
> it fixes the issue Will is describing in #13.
> 
> Can this patch get into the next version of gst-python?
> 
> With your patch:
> 
>     >>> from gi.repository import Gst
>     >>> Gst.init()
>     []
>     >>> s = Gst.Sample.new(Gst.Buffer.new_wrapped("Hello"))
>     >>> s.get_buffer().mini_object.is_writable()
>     True
>     >>> buf = s.get_buffer()
>     >>> buf.mini_object.is_writable()
>     True

I actually tested it a bit and it breaks things, it is too much of a hack and I
do not think we can merge that.

I have added similare hacks like
http://cgit.freedesktop.org/gstreamer/gst-python/commit/?id=3d19875eb7c20cedb4ab64e295c338ebd32f4b04
already, in that case it is good enough and will not break things, but this one
does not look safe.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.