[Bug 751104] make Gtk sinks usable from gst-launch

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751104

--- Comment #5 from Xavier Claessens <xclaesse at gmail.com> ---
Code should be duplicated in the non-gl sink as well, but let's first check if
that's correct, maybe we could add a base class when we have everything in
place.

I've been reading this code and I think it's lacking a few things to be solid:

1) It shouldn't call gtk_widget_realize() in _get_gl_context() but rather wait
for "realized" signal. But then what should happen if show_frame() is called
and the widget is still not realized?

2) It should handle "unrealized" signal, it can happen if the user remove the
widget from its parent, especially since we keep a strong ref so that won't
trigger "destroyed" signal.

3) Wondering if widget_destroy_cb() should g_clear_object(&gtk_sink->widget);
instead. If we keep a strong ref on a widget we are responsible to release that
ref on destroy normally. The widget cannot be used any more for any GTK work.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.