[Bug 750098] New element to convert GST_FLOW_ERROR into GST_FLOW_OK

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750098

--- Comment #8 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 305151:
 --> (https://bugzilla.gnome.org/review?bug=750098&attachment=305151)

Looks good. One thing I noticed is that it likely needs to reset keep_pushing
when a reconfigure event is received. Maybe check with
gst_pad_check_reconfigure() or add a source event handler to catch it.

Just some minor suggestions below, otherwise looks good.

::: gst/debugutils/gsterrorignore.c
@@ +23,3 @@
+ *
+ * Passes through all packets, but converts GST_FLOW_ERROR into GST_FLOW_OK
+ * (e.g. to allow other sinks to keep playing if one is misbehaving)

I think the documentation got outdated after the latest changes.

Might be worth mentioning the default values that are ignored.

@@ +120,3 @@
+
+  g_object_class_install_property (object_class, PROP_CONVERT_TO,
+      g_param_spec_enum ("convert-to", "GstFlowReturn to convert to",

convert-to looks not optimal to me but I don't have good ideas as well.
'converted-return'? 'ignored-return'?

But don't let this block you from pushing. I'd ask around in IRC for
suggestions, if no better options arise then I'd merge it as is.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.