[Bug 751149] dashdemux: add warning messages

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751149

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305545|none                        |reviewed
             status|                            |

--- Comment #3 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 305545:
 --> (https://bugzilla.gnome.org/review?bug=751149&attachment=305545)

Minor change needed. I'll merge both after this update.

::: ext/dash/gstmpdparser.c
@@ +3538,3 @@
       gst_mpdparser_representation_get_mimetype (adapt_set, representation);
   if (stream->mimeType == GST_STREAM_UNKNOWN) {
+    GST_WARNING ("No mime type in the representation, aborting...");

I think it would be better phrased as: "unknown mime type in the
representation, aborting..."

it is set to UNKNOWN when the mimetype doesn't start with audio, video or
application. It doesn't necessarily mean there was no mime type in the node.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.