[Bug 751147] appsink pull_preroll returns wrong segment in the sample

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751147

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305540|none                        |needs-work
             status|                            |

--- Comment #1 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 305540:
 --> (https://bugzilla.gnome.org/review?bug=751147&attachment=305540)

::: gst-libs/gst/app/gstappsink.c
@@ +572,3 @@
       GST_DEBUG_OBJECT (appsink, "receiving SEGMENT");
       g_queue_push_tail (priv->queue, gst_event_ref (event));
+      gst_event_copy_segment (event, &priv->preroll_segment);

Doesn't this mean that it will always have the latest segment received? I think
it should only consider the segment received before the preroll buffer, so it
should only do this while preroll == NULL.

For consistency it might also be a good idea to init it to UNDEFINED/TIME again
when ins _stop

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.