[Bug 750783] baseparse: reverse playback in pull mode
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Jun 19 08:15:55 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=750783
Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #305638|none |reviewed
status| |
--- Comment #6 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 305638:
--> (https://bugzilla.gnome.org/review?bug=750783&attachment=305638)
I only have small comment, otherwise looks good.
::: tests/check/libs/baseparse.c
@@ +23,3 @@
#include "config.h"
#endif
+
Oops, you added a white space here.
@@ +370,3 @@
+ case GST_EVENT_EOS:
+ if (loop) {
+ while (!g_main_loop_is_running (loop));
Some compilers will warn because of the empty statement. What I usually do is
add bracket with a comment /* nothing */
This is worth a comment like /* Wait for main loop to start */
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list