[Bug 751306] good plugins: fix some issues found using static analysis tool
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Jun 22 02:41:45 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=751306
Luis de Bethencourt <luis at debethencourt.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #305799|none |needs-work
status| |
--- Comment #7 from Luis de Bethencourt <luis at debethencourt.com> ---
Review of attachment 305799:
--> (https://bugzilla.gnome.org/review?bug=751306&attachment=305799)
True. Your code is safer if g_malloc fails, which looks like the original
intent.
Could you add an empty line between gst_reader->mik = mik; and the lines that
set gst_reader->core?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list