[Bug 751306] good plugins: fix some issues found using static analysis tool

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jun 22 02:45:59 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=751306

Luis de Bethencourt <luis at debethencourt.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305800|none                        |reviewed
             status|                            |

--- Comment #9 from Luis de Bethencourt <luis at debethencourt.com> ---
Review of attachment 305800:
 --> (https://bugzilla.gnome.org/review?bug=751306&attachment=305800)

If you look at the gst_matroska_track_free() code in matroska-ids.c. You will
see it doesn't check if the context exists or not before it dereferences the
structure.

The first line is:
  g_free (track->codec_id);

Are you sure about this patch?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list