[Bug 751306] good plugins: fix some issues found using static analysis tool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751306

Luis de Bethencourt <luis at debethencourt.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis at debethencourt.com

--- Comment #24 from Luis de Bethencourt <luis at debethencourt.com> ---
(In reply to Vineeth from comment #19)
> (In reply to Luis de Bethencourt from comment #9)
> > Review of attachment 305800 [details] [review] [review]:
> > 
> > If you look at the gst_matroska_track_free() code in matroska-ids.c. You
> > will see it doesn't check if the context exists or not before it
> > dereferences the structure.
> > 
> > The first line is:
> >   g_free (track->codec_id);
> > 
> > Are you sure about this patch?
> 
> the context check is actually useless at that point because, we are entering
> this code is in the if condition
>   if (context->type == 0 || context->codec_id == NULL || (ret != GST_FLOW_OK
>           && ret != GST_FLOW_EOS))
> 
> where context is already being referenced.

Good point :)

This is why it is important to make detailed commit messages. If not, we might
misunderstand the reasons for the patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.