[Bug 751071] applemedia: CMBlockBuffer can be non-contiguous
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Jun 22 05:14:03 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=751071
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #305422|none |needs-work
status| |
--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305422:
--> (https://bugzilla.gnome.org/review?bug=751071&attachment=305422)
::: sys/applemedia/coremediabuffer.c
@@ +159,3 @@
+ status =
+ CMBlockBufferGetDataPointer (block_buf, offset, &length_at_offset,
+ &total_length, &data);
total_length is always containing the total length from the beginning of the
block_buf? I.e. it will always return the same value here in this loop?
@@ +171,3 @@
+ break;
+ offset += length_at_offset;
+ } while (TRUE);
Why not "while (offset < total_length)"?
--
You are receiving this mail because:
You are the QA Contact for the bug.
More information about the gstreamer-bugs
mailing list