[Bug 738570] flvdemux: add support for accurate seeking
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Jun 22 06:38:27 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=738570
Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #299509|none |reviewed
status| |
--- Comment #12 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 299509:
--> (https://bugzilla.gnome.org/review?bug=738570&attachment=299509)
Looks good in general. I'm concern about the segment because start == time. But
at the same time, this won't make anything worst then it was before. I would
suggest merging. Setting as reviewed, so see if there is objection (or I missed
something obvious).
::: gst/flv/gstflvdemux.c
@@ +2563,3 @@
}
+ if (demux->segment.flags & GST_SEGMENT_FLAG_SEGMENT) {
Hmm, indeed.
@@ +2647,2 @@
/* Adjust the segment so that the keyframe fits in */
+ segment->start = segment->time = time;
I can't find if we properly offset the start/stop later to compensate the DTS
shift. In that case, time will be a little behind start (stream time will start
from zero, while TS won't match streamtime).
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list