[Bug 750865] gst-libav crash

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750865

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305693|none                        |reviewed
             status|                            |

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305693:
 --> (https://bugzilla.gnome.org/review?bug=750865&attachment=305693)

::: ext/libav/gstavviddec.c
@@ +1323,3 @@
+  if (G_UNLIKELY (ffmpegdec->picture->width != ffmpegdec->ctx_width
+          || GST_ROUND_UP_16 (ffmpegdec->picture->height) !=
+          GST_ROUND_UP_16 (ffmpegdec->ctx_height))) {

How does it end up being 1080 vs 1088? And in which order, is the picture or
the context information bigger?

It doesn't make much sense in any case, libav should tell us somewhere how many
lines have to be cropped in the end... and we should use that information
instead of arbitrarily rounding here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.