[Bug 751242] qtmux: Should be adding EDL on streams with PTS/DTS shift

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751242

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305727|none                        |reviewed
             status|                            |

--- Comment #4 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 305727:
 --> (https://bugzilla.gnome.org/review?bug=751242&attachment=305727)

::: gst/isomp4/gstqtmux.c
@@ +2476,3 @@
+      }
+
+      if (has_gap || has_shift) {

Why do you need to check for has_gap here? Shouldn't it be only has_shift?

@@ +2481,3 @@
+
+        atom_trak_set_elst_entry (qtpad->trak, 1, duration, shift,
+            (guint32) (1 * 65536.0));

I'd rather have a single empty entry at the beginning, having 2 empty ones
looks odd. It should work but I never saw files doing it.

Or is this needed due to that ambiguity of the empty entries at the beginning?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.