[Bug 751242] qtmux: Should be adding EDL on streams with PTS/DTS shift

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751242

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 305727:
 --> (https://bugzilla.gnome.org/review?bug=751242&attachment=305727)

::: gst/isomp4/gstqtmux.c
@@ +2476,3 @@
+      }
+
+      if (has_gap || has_shift) {

To not change the behaviour. In the past, we'd send two entry in presence of a
gap. The empty entry, and the edit. Now we have tree cases.

- The case we only have a gap
- The case we have a gap, and a shift
- the case we only have a shift

The 'empty' entry is sent when there is a gap. The second entry is sent if
media start need to be adjusted (shift) or if we had a gap (to keep the old
behaviour) I'm not sure why we need this empty entry, since in theory we could
just add the gap to the shift and that would be it. But I thought that this was
done with care in the past, and that there is most likely a good reason.

@@ +2481,3 @@
+
+        atom_trak_set_elst_entry (qtpad->trak, 1, duration, shift,
+            (guint32) (1 * 65536.0));

Only one is empty. The second entry is not, but it will adjust the media start
so time can be mapped properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.