[Bug 750761] inputselector: Handle different duration track selection

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750761

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305894|none                        |needs-work
             status|                            |

--- Comment #43 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305894:
 --> (https://bugzilla.gnome.org/review?bug=750761&attachment=305894)

::: plugins/elements/gstinputselector.c
@@ +459,3 @@
+static gboolean
+gst_input_selector_eos_wait (GstInputSelector * self, GstSelectorPad * pad)
+{

So this basically blocks EOS until the pad becomes the active pad, right? How
does that make things work correctly, and how is it different to before?


What would now still happen is that the active EOS is forwarded, and all other
streams are blocked on EOS until they become active. But if the active stream
is EOS, all buffers of the inactive streams are just dropped until they
themselves go EOS. So while we now can switch from an EOS to a non-EOS stream,
we will most likely still have dropped a lot of data instead of waiting at the
current time.

@@ +473,3 @@
+      }
+
+      gst_pad_push_event (self->srcpad, gst_event_new_eos ());

You should ideally forward exactly the EOS event that arrived here instead of a
new one :)

@@ -1016,3 @@
   }

-  if (sel->eos) {

I think sel->eos is completely unused now and could go away

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.