[Bug 749417] rtsp-client: add API to allow application to decide what requirements are supported

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749417

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305904|none                        |needs-work
             status|                            |

--- Comment #21 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 305904
  --> https://bugzilla.gnome.org/attachment.cgi?id=305904
rtsp-client: allow application to decide what requirements are supported

Looks good to me, just two more small niggles:

>+  /**
>+   * GstRTSPClient::check-requirements:
>+   * @auth: a #GstRTSPClient
>+   * @context: a #GstRTSPContext
>+   * @arr: a #GPtrArray of lines of Require in RTSP header

 -> NULL-terminated array of strings

>@@ -126,9 +126,10 @@ struct _GstRTSPClientClass {
> 
>   void     (*announce_request)        (GstRTSPClient *client, GstRTSPContext *ctx);
>   void     (*record_request)          (GstRTSPClient *client, GstRTSPContext *ctx);
>+  gchar*   (*check_requirements)      (GstRTSPClient *client, GstRTSPContext *ctx, GPtrArray * options);

Doesn't the last arg here need updating too?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.