[Bug 751387] New: aacparse: wrong src caps sample rate from LOAS frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751387

            Bug ID: 751387
           Summary: aacparse: wrong src caps sample rate from LOAS frame
    Classification: Platform
           Product: GStreamer
           Version: 1.5.1
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: guillaume.marquebielle at parrot.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 305925
  --> https://bugzilla.gnome.org/attachment.cgi?id=305925&action=edit
Patch fixing the issue

This issue is related to bug :

https://bugzilla.gnome.org/show_bug.cgi?id=751386

and cannot be reproduced with the AAC sample file without previous bug fixed.

I'm testing with some AAC file extracted from live TV stream.
Parsing a LOAS frame with a valid configuration, the sample rate is at first
set to 24000. Then, as the SBR flag is set, the sample rate is doubled and set
to 48000.

This leads to wrong src caps for the element. Indeed, all AAC decoders make a
difference between these 2 values as "sample_rate" and "extended_sample_rate".
But it's not correct in aacparse element to overwrite the first one by the
second one and setting src caps with the extended sample rate.

Playing this aac sample file with typical pipeline including an audiorate
element leads to stuttered audio.

The parser behavior should be the same for any transport type (ADTS, LOAS,
...).
As an example, VLC detects a 24000 sample rate with this file.

I provided a patch to fix this.
This issue is related to some discussion in :

https://bugzilla.gnome.org/show_bug.cgi?id=665394

Thx

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.