[Bug 751393] New: aacparse: LOAS config never retrieved

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751393

            Bug ID: 751393
           Summary: aacparse: LOAS config never retrieved
    Classification: Platform
           Product: GStreamer
           Version: 1.5.1
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: guillaume.marquebielle at parrot.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 305929
  --> https://bugzilla.gnome.org/attachment.cgi?id=305929&action=edit
Patch fixing the issue

I'm using aacparse on some live TV stream decoding pipeline.
I encountered some AAC sample for which the LOAS configuration is never
retrieved.


For each LOAS frame, "use previous config" bit is set, the whole frame size is
skipped and we never have any configuration.
It's not correct for the detect stream function to return TRUE if no previous
config is found.
Indeed, returning FALSE on detect stream function when no previous config has
been retrieved fixed this issue, as the handle frame function returned with
skip_size = 1. And parsing from next byte leads to retrieving some valid
configuration some steps further.

This should be cause by starting parsing from any position in frame.

I provided a patch to fix this and some AAC sample file to reproduce it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.