[Bug 751334] FLAC: memory leak on a specific media file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751334

--- Comment #13 from Vineeth <vineeth.tm at samsung.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #12)
> (In reply to Sebastian Dröge (slomo) from comment #5)
> > So there are probably two bugs here: 1) flacparse not accepting that file,
> > 2) flacparse/baseparse leaking everything because of 1)
> 
> So I'd redo this as:
> 
> 1) flacparse should set a valid streamheader (or drop)
> 2) flacdec should fail on invalid stream header

1) flacparse should set a valid streamheader (or drop)

flacparse is changed in
https://bugzilla.gnome.org/show_bug.cgi?id=684701
so that if we already have a valid streaminfo header, we just ignore if there
are any other header parsing errors.
This does not work with flacdec, becauase libflac does not handle this.
But libav flacdec is able to process even after ignoring the above errors. So
maybe this was added to let libav decode even with header error 

2) flacdec should fail on invalid stream header

for this, the solution suggested by Stephane Cerveau, seems to be proper.
because libflac cannot handle this file.
While trying to process till end of metadata for this file , libav changes
state to FLAC__STREAM_DECODER_ABORTED. Hence it is not able to proceed further,
and all the buffer being pushed to it is not being freed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.