[Bug 751420] basesink: need to deep-copy last buffer list in drain

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751420

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305980|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 305980:
 --> (https://bugzilla.gnome.org/review?bug=751420&attachment=305980)

::: gst/gstbufferlist.c
@@ +390,3 @@
+  for (i = 0; i < len; i++) {
+    GstBuffer *old = list->buffers[i];
+    gst_buffer_list_insert (result, i, gst_buffer_copy_deep (old));

Copying can fail for various reasons unfortunately, so you would insert NULL
buffers here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.