[Bug 745455] dashdemux: doesn't take the presentationTimeOffset into account.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745455

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #35 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Thiago Sousa Santos from comment #17)
> Review of attachment 298698 [details] [review]:
> 
> ::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
> @@ +745,3 @@
>      stream->segment = demux->segment;
> +    stream->segment.start = stream->segment.position =
> +        stream->fragment.timestamp;
> 
> I don't think this is correct because in the case of live streams we use the
> lowest pts of all streams as the segment.start (just a few lines above
> this). This might break sync of live streams.
> 
> I'm not sure if presentationTimeOffset makes sense with live streams, but
> the solution above will cause issues. I think something like:
> 
> if (stream_has_presentation_offset) { segment.start += offset }
> 
> might be better.

It seems like this comment was forgotten. And actually this commit breaks
seeking if there are "new streams" after the seek, as happens when switching
periods during seeking.

Looking into this now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.