[Bug 750863] tests: dashdemux: added unit tests for parsing period element

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Jun 24 03:24:15 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750863

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Florin Apostol from comment #10)
> (In reply to Sebastian Dröge (slomo) from comment #7)
> > Review of attachment 305321 [details] [review] [review]:
> > 
> > ::: tests/check/elements/dash_mpd.c
> > @@ -121,3 @@
> >    assert_equals_int (gst_date_time_get_second (availabilityEndTime), 50);
> >  
> >    assert_equals_int64 (mpdclient->mpd_node->mediaPresentationDuration,
> > 
> > Why not assert_equals_uint64() instead?
> 
> Because mediaPresentationDuration has type gint64. I also think it should be
> unsigned, so I raised a ticket to review all durations and change their type
> from signed to unsigned (https://bugzilla.gnome.org/show_bug.cgi?id=750847).

Alright, let's handle that in the other bug then :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list