[Bug 751306] good plugins: fix some issues found using static analysis tool

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jun 25 02:12:15 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=751306

--- Comment #26 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 305814
  --> https://bugzilla.gnome.org/attachment.cgi?id=305814
mikmod_reader: prevent possible null pointer derference

The correct fix here would have been to remove the if(gst_reader) check,
because it doesn't make sense. g_malloc() never returns NULL.

Also, please don't "fix" code that's not in use and not being built, that just
adds noise.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list