[Bug 751496] rtspsrc: Add new ntp-time-source property and deprecate use-pipeline-clock property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751496

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306102|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 306102:
 --> (https://bugzilla.gnome.org/review?bug=751496&attachment=306102)

::: gst/rtsp/gstrtspsrc.c
@@ +3423,3 @@
+          g_object_set (src->manager, "use-pipeline-clock", FALSE, NULL);
+        }
+      }

The code a few lines above is still always setting use-pipeline-clock to
something. I think the logic should be like in rtpbin:

if (src->use_pipeline_clock) {
  g_object_set (manager, "use-pipeline-clock", TRUE, NULL);
} else {
  g_object_set (manager, "ntp-time-source", src->ntp_time_source, NULL);
}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.