[Bug 751528] mpegdemux: Fix a prevent defect which dereference null return value. (Minor clean up)

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 26 00:54:39 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=751528

Vineeth <vineeth.tm at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306144|none                        |needs-work
             status|                            |

--- Comment #9 from Vineeth <vineeth.tm at samsung.com> ---
Review of attachment 306144:
 --> (https://bugzilla.gnome.org/review?bug=751528&attachment=306144)

::: gst/mpegdemux/gstmpegdemux.c
@@ +825,3 @@
       g_snprintf (cur_stream_name, 32, "audio-%d-language", i);
       lang_code = gst_structure_get_string (structure, cur_stream_name);
+      if (lang_code && temp) {

it might be better to break for default case and add
if (temp == NULL)
  continue;
before line 825

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list