[Bug 751538] New: gst_debug_log_default can't be removed during/before gst_init

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 26 04:53:01 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=751538

            Bug ID: 751538
           Summary: gst_debug_log_default can't be removed during/before
                    gst_init
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: All
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: hfink at toolsonair.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 306162
  --> https://bugzilla.gnome.org/attachment.cgi?id=306162&action=edit
Patch to only add the default logger in gst_init if no loggers have been added
yet.

When trying to only use external logging functions, the user might try to add
its own log handler and remove the default logging function before gst_init
(e.g. see
http://cgit.freedesktop.org/gstreamer/cerbero/tree/data/ndk-build/gstreamer_android-1.0.c.in#n482).
However, because gst_init (i.e. _priv_gst_debug_init, gstinfo.c)
unconditionally adds the gst_debug_log_default function to the list of active
loggers, the default log handlers is still being added and additionally used
later on.

This could be partially worked around by removing gst_debug_log_default after
gst_init (notice, though that removal of log functions might be racy, see
751440), but that would still cause logging during gst_init to be logged to the
default logger.

I have attached a patch for a simple solution for this use case: Only add the
default log function during gst_init if no log function has been added by the
user yet.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list