[Bug 750865] gst-libav crash

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=750865

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.3

--- Comment #42 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
commit 8cb8461f7e3c5ad0162e7caaca120f6b6577489a
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Jun 26 16:50:16 2015 +0200

    avviddec: Wrap the original AVBufferRef in our own buffer for the destroy
function

    Just adding a dummy buffer at the very end might not be enough as there
    already might be too many buffers.

commit 9b2c0c2dbcda3cd08aee98bc4bfdaabb1db11c63
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Jun 26 15:38:38 2015 +0200

    avviddec: libav will already copy the reordered_opaque pointer for us

    If we do it ourselves, it might get the wrong value if our assumptions are
    broken by libav at a later time.

commit 5b6c8ee8c96d773850cc213be00b5f43f60dbd55
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Fri Jun 26 15:34:30 2015 +0200

    avviddec: Negotiate based on the AVFrame information, not the context
information

    The context contains the information from the latest input frame, we're
    however interested in the information from the latest output frame. As we
have
    to negotiate for the buffer that is about to come next.

    This should fix some crashes that happened when both information got out of
    sync. If that happens now, we will do fallback allocation until the output
    is renegotiated too.

    https://bugzilla.gnome.org/show_bug.cgi?id=750865

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.