[Bug 751528] mpegdemux: Fix a prevent defect which dereference null return value. (Minor clean up)

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 26 09:32:58 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=751528

Luis de Bethencourt <luis at debethencourt.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |luis at debethencourt.com

--- Comment #13 from Luis de Bethencourt <luis at debethencourt.com> ---
Two things.

 - Don't compare to NULL, when you can directly do if (!temp).
 - In GStreamer's coding style we add a space between the 'if' and the '('.

Logic of patch is good. The code must check if gst_ps_demux_get_stream ()
returned NULL before dereferencing temp.

Change it to:

if (!temp)
  continue;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list