[Bug 745107] glimagesink: implement GstVideoOverlayCompositionMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745107

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #305563|none                        |needs-work
             status|                            |

--- Comment #32 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 305563:
 --> (https://bugzilla.gnome.org/review?bug=745107&attachment=305563)

::: gst-libs/gst/gl/gstglcompositionoverlay.c
@@ +113,3 @@
+  if (GST_GL_IS_CONTEXT (overlay->context)) {
+    gst_gl_context_thread_add (overlay->context,
+        gst_gl_composition_overlay_free_vertex_buffer, overlay);

The type check is suspicious. Also, what about unrefing the context ;-P

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.