[Bug 745107] glimagesink: implement GstVideoOverlayCompositionMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745107

--- Comment #35 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 305563:
 --> (https://bugzilla.gnome.org/review?bug=745107&attachment=305563)

::: gst-libs/gst/gl/gstglcompositionoverlay.c
@@ +299,3 @@
+  vmeta = gst_buffer_get_video_meta (comp_buffer);
+  gst_video_meta_map (vmeta, 0, &info, &raw_overlay_data, &stride,
+      GST_MAP_READ);

Here you map, then you unmap, and keep using the pointer after. Would be nice
to explain how this can be is safe ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.