[Bug 751650] New: dashdemux: extra validations needed when parsing the representation element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751650

            Bug ID: 751650
           Summary: dashdemux: extra validations needed when parsing the
                    representation element
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: florin.apostol at oregan.net
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Chapter 5.3.9.2 Segment base information mentions:

"
If the Representation contains more than one Media Segment, then either the
attribute @duration or the element SegmentTimeline shall be present. The
attribute @duration and the element SegmentTimeline shall not be present at the
same time.
"

I created a xml with no duration and no segmentTimeline:
  const gchar *xml =
      "<?xml version=\"1.0\"?>"
      "<MPD xmlns=\"urn:mpeg:dash:schema:mpd:2011\""
      " profiles=\"urn:mpeg:dash:profile:isoff-main:2011\""
      " availabilityStartTime=\"2015-03-24T0:0:0\""
      " mediaPresentationDuration=\"P0Y0M0DT3H3M30S\">"
      "<Period start=\"P0Y0M0DT0H0M10S\">"
      "  <AdaptationSet mimeType=\"video/mp4\">"
      "    <Representation>"
      "      <SegmentList>"
      "        <SegmentURL"
      "           media=\"TestMedia\" mediaRange=\"100-200\""
      "           index=\"TestIndex\" indexRange=\"300-400\""
      "        ></SegmentURL>"
      "      </SegmentList>"
      "    </Representation>"
      "  </AdaptationSet>"
      "</Period>"
      "</MPD>";

It parses fine, and I can setup streaming, but the
gst_mpd_client_get_next_fragment will return a fragment with duration 0:
elements/dash_mpd.c:3281:F:complexMPD:dash_mpdparser_segment_list:0:
'fragment.duration' (0) is not equal to 'expectedDuration * ((1000000 *
(__extension__ (1000LL))) / (__extension__ (1000LL)))' (11000000000000)

This is obvious due to missing duration or timeline in SegmentList's
MultipleSegmentBaseType.

I propose to add checks at the end of gst_mpdparser_parse_representation_node
to validate that either duration or timeline was specified. This means changing
the return type of gst_mpdparser_parse_representation_node,
gst_mpdparser_parse_adaptation_set_node, gst_mpdparser_parse_period_node,
gst_mpdparser_parse_root_node. If any will fail, the gst_mpd_parse function
will return false.

Will these extra validations be accepted?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.