[Bug 751444] RTP: Keep track of all estimated round trip times observed per each report block
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Jun 29 10:32:32 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=751444
--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Actually this code already does the right thing, it's just confusing with all
the different ssrcs and src variables there.
rtp_session_process_rr() has "source" as the one that sent the RR, i.e. the
media-receiver and passes that to rtp_session_process_rb(). So inside
rtp_session_process_rb(), "source" is the media-receiver source. Inside there
inside the loop, "ssrc" and "src" are the media-sender source (i.e. the one
about which the RB is). rtp_source_process_rb() is then called with "source"
(the media-receiver source), if "ssrc" and "src" are the internal source of
this session (i.e. it's not some other media sender but really our session
here).
Similar in rtp_session_process_sr(), "source" is the sender of the SR. So all
else being the same, on the receiver session the sender source will get updated
with the SR's RBs but as we only collect stats of internal sources, nothing
really will happen for this case.
So what exactly are you trying to accomplish here with your patch? That on
receiving a RR, the media-sender source will *also* get a list of all rtts? Or
that on receiving a SR, the media-receiver source will get a list of all rtts
of the other media-receivers?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list