[Bug 751554] GstVideoEncoder could expose a "max-keyframe-distance" property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751554

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
I think if some subclass already uses a property named like that it's not a
problem, it will just override the base class property.

vtenc has similar properties called "max-keyframe-interval-duration" and
"max-keyframe-interval", see
http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/sys/applemedia/vtenc.c?id=b88e4304f1ddb4441cc076762010d150b72a4252

I think specifying the interval/distance in time is more natural and versatile
than in frames though, and I'd claim that most people actually want to specify
it in time.

Nicolas: it depends on the encoder API. If it provides a way to specify the max
interval in time, then it's not a problem. Otherwise the base class can
probably just use the force-keyframe API to make sure a new keyframe is forced
when needed (it knows when the last keyframe came out; it knows about pending
frames inside the encoder (and can probably assume that it's all a single GOP,
no? Details tbd).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.