[Bug 751311] rtp: Dynamic dropout / reorder limits

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751311

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306393|none                        |needs-work
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 306393:
 --> (https://bugzilla.gnome.org/review?bug=751311&attachment=306393)

::: gst/rtpmanager/gstrtpbin.c
@@ +2204,3 @@
+  g_object_class_install_property (gobject_class, PROP_MAX_MISORDER_TIME,
+      g_param_spec_int ("max-misorder-time", "Max misorder time",
+          "The maximum time (milliseconds) of misordered packets tolerated.",

Why milliseconds and not nanoseconds?

::: gst/rtpmanager/rtpsource.c
@@ +42,3 @@
 #define DEFAULT_PROBATION            RTP_DEFAULT_PROBATION
+#define DEFAULT_MAX_DROPOUT_TIME     -1
+#define DEFAULT_MAX_MISORDER_TIME    -1

The defaults should probably be like in the RFC: 1 minute and 2 seconds. And we
could make -1 mean to never consider something as dropout or outside
reordering.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.