[Bug 751311] rtp: Dynamic dropout / reorder limits
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Jun 30 07:15:04 PDT 2015
https://bugzilla.gnome.org/show_bug.cgi?id=751311
--- Comment #24 from Miguel París Díaz <mparisdiaz at gmail.com> ---
Review of attachment 306390:
--> (https://bugzilla.gnome.org/review?bug=751311&attachment=306390)
::: gst/rtpmanager/rtpstats.c
@@ +39,3 @@
+guint32
+gst_rtp_packet_rate_ctx_update (RTPPacketRateCtx * ctx, guint16 seqnum,
+ guint32 ts, gint32 clock_rate)
What happens if it changes?
@@ +60,3 @@
+ }
+
+ diff_ts = ts - ctx->last_ts;
How can I manage wraparounds?
There is any utility?
Do you mean use this values?:
rtpsource: RTPPacketInfo.ntpnstime
jitterbuffer: dts
@@ +63,3 @@
+ diff_ts = gst_util_uint64_scale_int (diff_ts, GST_USECOND, clock_rate);
+ ctx->avg_packet_rate =
+ ((7 * (ctx->avg_packet_rate + 1)) + (1000 * diff_seqnum / diff_ts)) / 8;
This may be more inefficient?
Or something insignificant?
::: gst/rtpmanager/rtpstats.h
@@ +209,3 @@
+void gst_rtp_packet_rate_ctx_destroy (RTPPacketRateCtx *ctx);
+guint32 gst_rtp_packet_rate_ctx_update (RTPPacketRateCtx *ctx, guint16 seqnum,
guint32 ts, gint32 clock_rate);
+guint32 gst_rtp_packet_rate_ctx_get (RTPPacketRateCtx *ctx);
I do not know what do you mean
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list