[Bug 745441] v4l2: Detect lossed frame and send GAPs event

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745441

--- Comment #4 from Peter Seiderer <ps.report at gmx.net> ---
(In reply to Nicolas Dufresne (stormer) from comment #2)
> Review of attachment 298267 [details] [review]:
> 
> Do you plan on a patchset to actually do something with that ? Lost frame
> should be signalled using GAP event. Note about patch submission that we
> don't use Signed-off-by in this project. We do enforce bugzilla
> cross-reference, so you last line should be this bug URI.
> 

The primary goal of this patchset was to show a usage of the sequence counter
as offset (first patch). Secondary usage was performance checking/optimisation
of
gst-launch pipelines and a custom application.

I can try to implement GAP events instead...

Thanks for the hint for Signed-off/Bug-Refrence, will try to get it
right on next submission...

> ::: sys/v4l2/gstv4l2src.c
> @@ -753,3 @@
> -    GST_BUFFER_OFFSET (*buf) = v4l2src->offset++;
> -    GST_BUFFER_OFFSET_END (*buf) = v4l2src->offset;
> -  }
> 
> Is there a reason to move code around here ?

Yes, the reason was to get the timestamps in the 'lost frames' warning
message right (see the timestamp adjusting code between the original
location and the new location), means the timestamp is the
same as you see pipeline-downstream...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.