[Bug 745192] matroskademux: V_MS-VFW-FOURCC streams have DTS instead of PTS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745192

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298389|none                        |needs-work
             status|                            |

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 298389:
 --> (https://bugzilla.gnome.org/review?bug=745192&attachment=298389)

::: gst/matroska/matroska-mux.c
@@ +3480,3 @@
+        || gst_matroska_track_get_buffer_timestamp (collect_pad->track,
+            buf) != collect_pad->last_collected_duration_ts) {
+      collect_pad->duration += GST_BUFFER_DURATION (buf);

I think the duration should rather be the difference between the first buffer's
timestamp and the last buffer's timestamp+duration. Counting it here is not
going to give useful results and accumulates rounding errors.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.