[Bug 743925] osxaudiosink won't reconfigure sink caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=743925

--- Comment #8 from Ilya Konstantinov <ilya.konstantinov at gmail.com> ---
On my OS X, the test program exhibits the same behavior without the patch as
well.

About the correction to the (In reply to Arun Raghavan from comment #4)
> I've made a couple of small modifications to your patch for correctness.

The old code didn't get template caps either if the ring buffer wasn't open.

I would however change this:
    if (!ret && osxsink->cached_caps)
      ret = gst_caps_ref (osxsink->cached_caps);
to:
    if (osxsink->cached_caps)
      ret = gst_caps_ref (osxsink->cached_caps);

I know the current get_caps are bad, but I was planning to address this in the
mega-patch to bug 743758.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.