[Bug 745438] v4l2/gstv4l2bufferpool: overwrite PTS only in case of capture device

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Mar 3 06:04:13 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=745438

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298374|accepted-commit_now         |needs-work
             status|                            |

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 298374:
 --> (https://bugzilla.gnome.org/review?bug=745438&attachment=298374)

::: sys/v4l2/gstv4l2bufferpool.c
@@ +1240,3 @@
+   * buffer to multiple video sinks)
+   */
+  if (obj->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {

Sorry, I missed that initially. You forgot about the other cases
(CAPTURE_MPLANE, OUTPUT_MPLANE). You could do to cover them all:

if (!V4L2_TYPE_IS_OUTPUT (v4l2object->type))

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list