[Bug 741030] theoradec: Sets video-meta width/height from padded values

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=741030

--- Comment #41 from Jan Schmidt <thaytan at noraisin.net> ---
(In reply to Nicolas Dufresne (stormer) from comment #39)
> (In reply to Sebastian Dröge (slomo) from comment #38)
> > (In reply to Nicolas Dufresne (stormer) from comment #36)
> > > (In reply to Sebastian Dröge (slomo) from comment #33)
> > > > All these are not new problems except for b), as such don't seem like
> > > > blockers. b) should be fixed, and Jan's patch should do that and we should
> > > > get it in after making sure it doesn't break anything. The others should be
> > > > fixed at some point
> > > > 
> > > 
> > > For your interest, Jan patch would fail in gst-validate small run. Didn't
> > > have time to dig into it.
> > 
> > Should we just get it in for now though? I mean currently gst-validate will
> > fail with the assertion in gst_video_frame_map(), and the patch is at least
> > a step in the right direction. And having it merged might allow us to easily
> > get some more information on what goes wrong
> 
> No, currently gst-validate don't hit these assertion. It breaks the case
> where there is no cropping, the one that still works, the only one currently
> tested in gst-validate iirc.

I'm not sure how gst-validate would fail with this patch applied then -
uncropped should have both the allocation and caps GstVideoMeta be the same and
work regardless.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.