[Bug 745455] dashdemux doesn't take the presentationTimeOffset into account.
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Mar 6 03:36:01 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=745455
--- Comment #14 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
(In reply to Thiago Sousa Santos from comment #8)
> Review of attachment 298289 [details] [review]:
>
> ::: ext/dash/gstmpdparser.c
> @@ +3626,3 @@
> + offset /= stream->cur_seg_template->MultSegBaseType->
> + SegBaseType->timescale;
> + }
>
> Why not store this somewhere easier already scaled to the timestamp to avoid
> this long if here?
>
> Just having a stream->presentationTimeOffset that you can simply add below
> makes this clearer.
Done, I also slightly refactored the code around the setting at the same time,
makes it a bit easier to read and spares some inderections.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list