[Bug 745455] dashdemux doesn't take the presentationTimeOffset into account.
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Fri Mar 6 05:23:08 PST 2015
https://bugzilla.gnome.org/show_bug.cgi?id=745455
Thiago Sousa Santos <thiagossantos at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #298698|none |reviewed
status| |
--- Comment #17 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 298698:
--> (https://bugzilla.gnome.org/review?bug=745455&attachment=298698)
::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +745,3 @@
stream->segment = demux->segment;
+ stream->segment.start = stream->segment.position =
+ stream->fragment.timestamp;
I don't think this is correct because in the case of live streams we use the
lowest pts of all streams as the segment.start (just a few lines above this).
This might break sync of live streams.
I'm not sure if presentationTimeOffset makes sense with live streams, but the
solution above will cause issues. I think something like:
if (stream_has_presentation_offset) { segment.start += offset }
might be better.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list