[Bug 740124] mpegtsmux: set group-id in stream-start event

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=740124

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thiagossantos at gmail.com

--- Comment #5 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Aurélien Zanelli from comment #4)
> (In reply to Thiago Sousa Santos from comment #3)
> > Review of attachment 290720 [details] [review] [review]:
> > 
> > ::: gst/mpegtsmux/mpegtsmux.c
> > @@ +1680,3 @@
> > +  stream_start = gst_event_new_stream_start (s_id);
> > +  gst_event_set_group_id (stream_start, gst_util_group_id_next ());
> > +  gst_pad_push_event (mux->srcpad, stream_start);
> > 
> > Isn't the purpose of group-id to have streams that are to be played together
> > have the same group-id?
> Yes.
> 
> Currently, I don't clearly understand your remark, so correct me if I'm
> wrong:
> it is a muxer which have only one src pad, hence it create only one output
> stream and one stream_start event is pushed downstream. There is no multiple
> stream in this case so no need to store and reuse the group id if it's what
> you meant.

Sorry. I thought you were talking about the demuxer. I don't see an use case
where that would be relevant for muxers other than just silencing the FIXME.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.