[Bug 745740] camerabin: update zoom param spec if video source changes its max-zoom

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Mar 7 05:53:35 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=745740

--- Comment #5 from Mohammed Sameer <msameer at foolab.org> ---
(In reply to Thiago Sousa Santos from comment #4)
> Does your source always do a max-zoom notify when it reaches playing to
> notify about its zoom maximum?

Yes it does.

> I'm considering the case where a source would have a different max-zoom but
> doesn't notify because it is always the same since the beginning. So the
> camerabin API and the source API wouldn't be agreeing to each other.

It still depends on how you expect the API to be used :-)
a GObject property needs to have a default min, current and max values anyway
so it depends on what the developer of the custom source chooses for those
values.

> Do you see this as possible?
It seems possible but not like we get a new camera source every day ;-)

I'd personally not be concerned about it but if you still believe it's a
possibility then I can try to find time to create another patch.

There is also something I noticed, why does camerabin proxy the zoom and
max-zoom only? Either we proxy all the photography properties or we proxy none.
I was tempted to suggest removing those properties completely.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list