[Bug 745768] aggregator: Add internal queue

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745768

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|Normal                      |High
             Status|NEW                         |NEEDINFO
           Severity|normal                      |critical

--- Comment #13 from Olivier Crête <olivier.crete at ocrete.ca> ---
(In reply to Sebastian Dröge (slomo) from comment #10)
> Review of attachment 298761 [details] [review]:
> 
> ::: gst-libs/gst/base/gstaggregator.c
> @@ +1578,3 @@
>  
> +  if (latency)
> +    self->priv->latency_live = TRUE;
> 
> I don't think this change is correct. Why would you assume a live pipeline
> just because the aggregator subclass told the base class about its latency?
> Both videoaggregator and audiomixer always set a latency currently.

That is only triggered if the latency property is set, not if a subclass sets a
latency. That said, I'm more and more convinced that if the latency property is
set to non-0, it should ignore the liveness of the source and always try to
sync on the clock. Otherwise, if you have a mixer where one of the pads
receives nothing from the start, it waits forever.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.