[Bug 745768] aggregator: Add internal queue

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745768

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Olivier Crête from comment #13)
> (In reply to Sebastian Dröge (slomo) from comment #10)
> > Review of attachment 298761 [details] [review] [review]:
> > 
> > ::: gst-libs/gst/base/gstaggregator.c
> > @@ +1578,3 @@
> >  
> > +  if (latency)
> > +    self->priv->latency_live = TRUE;
> > 
> > I don't think this change is correct. Why would you assume a live pipeline
> > just because the aggregator subclass told the base class about its latency?
> > Both videoaggregator and audiomixer always set a latency currently.
> 
> That is only triggered if the latency property is set, not if a subclass
> sets a latency. That said, I'm more and more convinced that if the latency
> property is set to non-0, it should ignore the liveness of the source and
> always try to sync on the clock. Otherwise, if you have a mixer where one of
> the pads receives nothing from the start, it waits forever.

Why does it wait forever then? The latency property only has an effect if one
of the upstreams is live, so in your case it shouldn't make any difference if
it is set or not.


But always syncing to the clock if the property is set seems a bit weird, what
about just adding a sync property to aggregator like in identity instead? That
would also allow you to force syncing to the clock with latency=0.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.