[Bug 745518] http.playback.reverse_playback.vorbis_theora.1.ogg should be failed

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745518

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298990|none                        |needs-work
             status|                            |
 Attachment #298990|none                        |needs-work
             status|                            |
 Attachment #298990|none                        |needs-work
             status|                            |

--- Comment #7 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 298990:
 --> (https://bugzilla.gnome.org/review?bug=745518&attachment=298990)

It is pretty much the same thing as what I proposed, can you check the patch I
proposed at: http://phabricator.freedesktop.org/D35 ?

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                  
_QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG        
_QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG            
_QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just
no work I think

--- Comment #8 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 298990:
 --> (https://bugzilla.gnome.org/review?bug=745518&attachment=298990)

It is pretty much the same thing as what I proposed, can you check the patch I
proposed at: http://phabricator.freedesktop.org/D35 ?

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                  
_QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG        
_QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG            
_QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just
no work I think

--- Comment #9 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 298990:
 --> (https://bugzilla.gnome.org/review?bug=745518&attachment=298990)

It is pretty much the same thing as what I propose

::: validate/gst/validate/gst-validate-report.h
@@ +87,3 @@
 #define EVENT_SEEK_NOT_HANDLED                  
_QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG        
_QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_RESULT_RATE_WRONG            
_QUARK("event::seek-result-rate-wrong")

You would have to also register that type, without doing it reporting will just
no work I think

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.